Skip to content

node-api: use WriteOneByteV2 in napi_get_value_string_latin1 #58325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2025
Merged

node-api: use WriteOneByteV2 in napi_get_value_string_latin1 #58325

merged 1 commit into from
May 16, 2025

Conversation

legendecas
Copy link
Member

Replace usage of deprecated WriteOneByte with WriteOneByteV2.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/node-api

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. labels May 14, 2025
@codecov Codecov
Copy link

codecov bot commented May 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.22%. Comparing base (b197355) to head (69d4597).
Report is 18 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58325      +/-   ##
==========================================
- Coverage   90.23%   90.22%   -0.01%     
==========================================
  Files         633      633              
  Lines      186818   186819       +1     
  Branches    36668    36670       +2     
==========================================
- Hits       168578   168566      -12     
- Misses      11036    11043       +7     
- Partials     7204     7210       +6
Files with missing lines Coverage Δ
src/js_native_api_v8.cc 76.54% <100.00%> (+0.01%) ⬆️

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label May 15, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 15, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66803/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66830/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66836/

mhdawson
mhdawson approved these changes May 16, 2025
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson mhdawson moved this from Need Triage to In Progress in Node-API Team Project May 16, 2025
@legendecas legendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label May 16, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 16, 2025
@nodejs-github-bot nodejs-github-bot merged commit 5984444 into nodejs:main May 16, 2025
73 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 5984444

@github-project-automation github-project-automation bot moved this from In Progress to Done in Node-API Team Project May 16, 2025
@legendecas legendecas deleted the node-api/write-one-byte-v2 branch May 16, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API.
Projects
Node-API Team Project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@legendecas @nodejs-github-bot @anonrig @mhdawson